-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate XML writer for S3 operations #4796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Applin
reviewed
Dec 21, 2023
...s-xml-protocol/src/main/java/software/amazon/awssdk/protocols/xml/AwsXmlProtocolFactory.java
Outdated
Show resolved
Hide resolved
...otocol/src/main/java/software/amazon/awssdk/protocols/xml/internal/marshall/S3XmlWriter.java
Show resolved
Hide resolved
zoewangg
reviewed
Dec 22, 2023
...otocol/src/main/java/software/amazon/awssdk/protocols/xml/internal/marshall/S3XmlWriter.java
Outdated
Show resolved
Hide resolved
...otocol/src/main/java/software/amazon/awssdk/protocols/xml/internal/marshall/S3XmlWriter.java
Outdated
Show resolved
Hide resolved
services/s3/src/it/java/software/amazon/awssdk/services/s3/DeleteObjectsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...protocol/src/main/java/software/amazon/awssdk/protocols/xml/internal/marshall/XmlWriter.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Jan 3, 2024
...tocol/src/main/java/software/amazon/awssdk/protocols/xml/internal/marshall/XmlGenerator.java
Show resolved
Hide resolved
services/s3/src/it/java/software/amazon/awssdk/services/s3/DeleteObjectsIntegrationTest.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Jan 4, 2024
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 15 New issues |
L-Applin
approved these changes
Jan 4, 2024
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, when calling
DeleteObjects
with an object key that contains characters that need to be escaped in XML, and is encoded, the decoded key is deleted instead.e.g., sending
DeleteObjectsRequest
specifying the key<Key>objectId</Key>
deletes the object with the key<Key>objectId</Key>
This is because the
XmlWriter
performs unescaping.Modifications
Created a separate
S3XmlWriter
which does not perform unescaping, which will be used exclusively for S3 operations.Testing
Added integ tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License