Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate XML writer for S3 operations #4796

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

davidh44
Copy link
Contributor

Motivation and Context

Currently, when calling DeleteObjects with an object key that contains characters that need to be escaped in XML, and is encoded, the decoded key is deleted instead.

e.g., sending DeleteObjectsRequest specifying the key &lt;Key&gt;objectId&lt;/Key&gt; deletes the object with the key <Key>objectId</Key>

This is because the XmlWriter performs unescaping.

Modifications

Created a separate S3XmlWriter which does not perform unescaping, which will be used exclusively for S3 operations.

Testing

Added integ tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner December 20, 2023 21:13
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

15 New issues
0 Security Hotspots
86.9% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

@davidh44 davidh44 merged commit 14840ca into master Jan 9, 2024
14 checks passed
@davidh44 davidh44 deleted the hdavidh/fix-deleteObjects-encodedKey-bug branch January 9, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants