-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ProgressUpdater class to expose methods to invoke listeners to update request status #4861
Merged
anirudh9391
merged 35 commits into
feature/anirudkr-progress-listener
from
dev/progress-listener
Feb 14, 2024
Merged
Create ProgressUpdater class to expose methods to invoke listeners to update request status #4861
anirudh9391
merged 35 commits into
feature/anirudkr-progress-listener
from
dev/progress-listener
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Jan 30, 2024
core/sdk-core/src/main/java/software/amazon/awssdk/core/protocol/VoidSdkResponse.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/protocol/VoidSdkResponse.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
...est/java/software/amazon/awssdk/core/internal/progress/listener/CaptureProgressListener.java
Outdated
Show resolved
Hide resolved
...rc/test/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdaterTest.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
...rc/test/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdaterTest.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Feb 13, 2024
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Feb 13, 2024
...re/src/main/java/software/amazon/awssdk/core/internal/progress/listener/ProgressUpdater.java
Outdated
Show resolved
Hide resolved
…callback methods in ProgressUpdater
zoewangg
approved these changes
Feb 13, 2024
|
||
/** | ||
* SdkExchange Progress makes it available for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unfinished sentence
Quality Gate failedFailed conditions |
anirudh9391
merged commit Feb 14, 2024
5613092
into
feature/anirudkr-progress-listener
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ProgressListenerContext class to enable request state storage, and a ProgressUpdater class exposing methods corresponding to progress change methods.
Motivation and Context
Generic Progress Listeners in V2 is addressing a parity gap with V1
Modifications
Incorporated ProgressUpdater into ExecutionContext
Added a Logging Progress Listener
Testing
Unit Tests validating end to end invocation of all ProgressListener methods
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License