Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ProgressUpdater class to expose methods to invoke listeners to update request status #4861

Merged
merged 35 commits into from
Feb 14, 2024

Conversation

anirudh9391
Copy link
Contributor

@anirudh9391 anirudh9391 commented Jan 30, 2024

Added a ProgressListenerContext class to enable request state storage, and a ProgressUpdater class exposing methods corresponding to progress change methods.

Motivation and Context

Generic Progress Listeners in V2 is addressing a parity gap with V1

Modifications

  1. Progress Updater class exposing methods for users to update request progress state. This invokes methods of a Listener Invoker class to store a list of listeners and exposed methods to access each ProgressListener method
  • requestPrepared
  • requestHeaderSent
  • requestBytesSent
  • responseHeaderReceived
  • responseBytesReceived
  • executionSuccessful
  • executionFailure
  1. Incorporated ProgressUpdater into ExecutionContext

  2. Added a Logging Progress Listener

Testing

Unit Tests validating end to end invocation of all ProgressListener methods

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ x] I confirm that this pull request can be released under the Apache 2 license

…ure context objects. Added progress listener method to RequestOverrideConfiguration
@anirudh9391 anirudh9391 requested a review from a team as a code owner January 30, 2024 00:39

/**
* SdkExchange Progress makes it available for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unfinished sentence

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@anirudh9391 anirudh9391 merged commit 5613092 into feature/anirudkr-progress-listener Feb 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants