Enable setting multipart to true/false by defining it as a custom client context parameter #4899
Conversation
…ent context param
| @@ -68,7 +64,7 @@ private static Supplier<S3AsyncClient> defaultS3AsyncClient() { | |||
| if (crtInClasspath()) { | |||
| return S3AsyncClient::crtCreate; | |||
| } | |||
| return S3AsyncClient::create; | |||
| return S3AsyncClient::createWithMultipartEnabled; | |||
There was a problem hiding this comment.
| return S3AsyncClient::createWithMultipartEnabled; | |
| return () -> S3AsyncClient.builder().multipartEnabled(true).build(); |
Could we avoid creating the new static method createWithMultipartEnabled on the client and just use this instead?
There was a problem hiding this comment.
Yeah i contemplated using this, just thought it might be neater to create a new one. Sure, i can change it to this, it makes sense to have one lesser static method to have to test
| }, | ||
| { | ||
| "methodName": "createWithMultipartEnabled", | ||
| "clientType": "async", | ||
| "instanceType": "software.amazon.awssdk.services.s3.S3AsyncClient", | ||
| "returnType": "software.amazon.awssdk.services.s3.S3AsyncClient", | ||
| "statement": "builder().multipartEnabled(true).build()", | ||
| "javaDoc": "Create a {@link S3AsyncClient} with multi-part operations enabled" |
There was a problem hiding this comment.
see other comment about static method
There was a problem hiding this comment.
Got it. I can change this
| public static final AttributeMap.Key<Boolean> MULTIPART_ENABLED_KEY = | ||
| new AttributeMap.Key<Boolean>(Boolean.class){}; |
There was a problem hiding this comment.
If we dont need it anymore, we should also remove it from customization.config: "contextParamEnabledKey": "S3AsyncClientDecorator.MULTIPART_ENABLED_KEY" ln245
There was a problem hiding this comment.
Ah okay. I missed that one.
…ent context parameter
|
Multipart upload can be set as a client configuration parameter and is accessible at the time of instantiation. This allows classes that instantiate the S3AsyncClient to validate this parameter.
Modifications
1)Incorporated multiPartEnabled as a custom client configuration parameter by defining it in customization.config. The codegen module generates getter and setter methods for this parameter.
2) By default, set multipartEnabled = true in the S3AsyncClient
3) Removed code that sets multiPart Enabled on the client directly
Testing
Unit Tests to validate that
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License