Implementation of MultipartDownloaderSubscriber #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gTransformer PR comments. Wiremock tests. - Use builder and template methods in DelegatingBufferingSubscriber
dagnir
reviewed
Feb 14, 2024
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
.../sdk-core/src/main/java/software/amazon/awssdk/core/internal/async/SplittingTransformer.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/BaseSubscriberAdapter.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/BaseSubscriberAdapter.java
Show resolved
Hide resolved
zoewangg
reviewed
Feb 14, 2024
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloaderSubscriber.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/DelegatingBufferingSubscriber.java
Outdated
Show resolved
Hide resolved
…-static to do so. - removed trace/debug logging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix last comments on PR #4826.
MultipartDownloaderSubscriber receives the
AsyncResponseTransformerpublished bySplittingTransformerand performs the get-object requests for the individual parts of the s3 object.MultipartDownloaderSubscriberWiremockTestcurrently only contains happy-path tests, I intend to add more cases soon but still opened the PR so we can start reviewing it earlier.