Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ca-west-1" endpoint for the ec2 service #4934

Closed
wants to merge 1 commit into from
Closed

Add "ca-west-1" endpoint for the ec2 service #4934

wants to merge 1 commit into from

Conversation

daeho-ro
Copy link

Motivation and Context

It seems that the ca-west-1 region endpoint is missing for ec2 service.
#4805

Modifications

I have added the region endpoint for ec2 service.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@daeho-ro daeho-ro requested a review from a team as a code owner February 15, 2024 04:14
@debora-ito
Copy link
Member

Hi @daeho-ro, the endpoints.json file needs to be updated upstream in our release process, we can't change it here because the changes will be overwritten by the next release.

I've already reached out internally to the team that manages the endpoints file. Let's track the progress in #4805.

@debora-ito debora-ito closed this Feb 16, 2024
@daeho-ro
Copy link
Author

@debora-ito Thanks for the notification. :)

@daeho-ro daeho-ro deleted the ca-west-1 branch February 16, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants