Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Event Notifications parsers #4994

Merged
merged 29 commits into from
Mar 15, 2024
Merged

Conversation

L-Applin
Copy link
Contributor

@L-Applin L-Applin commented Mar 6, 2024

Adds a new module that contains the classes used to represent Amazon S3 Event Notifications, and de/serializer from/to json format. #1197

Motivation and Context

The AWS SDK for Java v1 provides this fucntionality but it had not been ported to v2 yet

Modifications

New module with POJO classes and de/serialiser classses

Testing

new unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@L-Applin L-Applin requested a review from a team as a code owner March 6, 2024 19:48
L-Applin added 5 commits March 8, 2024 15:18
- refactor expectStringOrNull
- Added GlacierEventData documentation
- removed some explicit version in pom
- make S3EventNotificationRecord SdkTestInternalApi only and use getters instead
Copy link
Contributor

@millems millems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I think we need more javadoc on the public getters/setters. A link to the service docs and/or the descriptions from those docs.

Copy link

@L-Applin L-Applin merged commit 7b61bd0 into master Mar 15, 2024
17 checks passed
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
* s3-event-notifications new module

* fix pom.xml

* Equals, hashcode, tostring. More tests. Remove Entity suffix.

* handle null fields

* Checkstyle

* changelog

* new module checklist

* readme, extra fields, cleanup

* remove duplicate dependency

* update pom version

* update pom version, for real this time

* fix pom

* cleanup

* documentation

* PR comments
- refactor expectStringOrNull
- Added GlacierEventData documentation
- removed some explicit version in pom

* update pom, again

* PR comment:
- make S3EventNotificationRecord SdkTestInternalApi only and use getters instead

* Suppress non-final fields in EqualsVerifier test.

* update pom to 2.25.7-SNAPSHOT

* make S3EventNotificationRecord test constructor package-protected

* maven version
@L-Applin L-Applin deleted the olapplin/s3-event-notifications branch November 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants