-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 Event Notifications parsers #4994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into olapplin/s3-event-notifications
millems
reviewed
Mar 8, 2024
.../software/amazon/awssdk/eventnotifications/s3/internal/DefaultS3EventNotificationReader.java
Show resolved
Hide resolved
...tions/src/main/java/software/amazon/awssdk/eventnotifications/s3/model/GlacierEventData.java
Show resolved
Hide resolved
.../main/java/software/amazon/awssdk/eventnotifications/s3/model/S3EventNotificationRecord.java
Outdated
Show resolved
Hide resolved
- refactor expectStringOrNull - Added GlacierEventData documentation - removed some explicit version in pom
… into olapplin/s3-event-notifications
- make S3EventNotificationRecord SdkTestInternalApi only and use getters instead
millems
reviewed
Mar 8, 2024
.../main/java/software/amazon/awssdk/eventnotifications/s3/model/S3EventNotificationRecord.java
Outdated
Show resolved
Hide resolved
millems
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I think we need more javadoc on the public getters/setters. A link to the service docs and/or the descriptions from those docs.
Quality Gate passedIssues Measures |
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
* s3-event-notifications new module * fix pom.xml * Equals, hashcode, tostring. More tests. Remove Entity suffix. * handle null fields * Checkstyle * changelog * new module checklist * readme, extra fields, cleanup * remove duplicate dependency * update pom version * update pom version, for real this time * fix pom * cleanup * documentation * PR comments - refactor expectStringOrNull - Added GlacierEventData documentation - removed some explicit version in pom * update pom, again * PR comment: - make S3EventNotificationRecord SdkTestInternalApi only and use getters instead * Suppress non-final fields in EqualsVerifier test. * update pom to 2.25.7-SNAPSHOT * make S3EventNotificationRecord test constructor package-protected * maven version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new module that contains the classes used to represent Amazon S3 Event Notifications, and de/serializer from/to json format. #1197
Motivation and Context
The AWS SDK for Java v1 provides this fucntionality but it had not been ported to v2 yet
Modifications
New module with POJO classes and de/serialiser classses
Testing
new unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License