Allows users to configure subscribeTimeout for BlockingInputStreamAsyncRequestBody #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
L-Applin
reviewed
Mar 19, 2024
...ore/src/main/java/software/amazon/awssdk/core/async/BlockingInputStreamAsyncRequestBody.java
Outdated
Show resolved
Hide resolved
L-Applin
approved these changes
Mar 25, 2024
|
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
…ncRequestBody (aws#5020) * allow user to configure subscribe timeout for input stream * Fix compilation error * Address feedback --------- Co-authored-by: Ben Arnao <benarnao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Continuation of #5017
Similar to
BlockingOutputStreamAsyncRequestBody,BlockingInputStreamAsyncRequestBodywill timeout if the async request body is not subscribed after 10 seconds.S3 CRT client will queue requests once it runs out of connections and if users send a lot of requests, it's likely those requests will not get executed within 10 seconds.
Allows users to configure subscribeTimeout for BlockingInputStreamAsyncRequestBody
Modifications
Exposes an option to allows users to configure subscribeTimeout for BlockingInputStreamAsyncRequestBody
Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License