-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reflect-config.json to s3-transfer-manager #5184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add a changelog entry? You can just run the scripts/new-change script
and follow the instructions.
Hey @zoewangg -
Sadly I got this error:
|
a222b2e
to
2d58209
Compare
@klopfdreh could you try running |
Because I didn't use any markdown / links in my comment I commented out the linkify function. I added the newly generated json to the change and force pushed it, so that it is only one commit. |
I did, but the first line is python2 |
2d58209
to
015a3e0
Compare
I removed the duplicated json files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Triggering builds
Quality Gate passedIssues Measures |
@all-contributors please add @klopfdreh for code |
I've put up a pull request to add @klopfdreh! 🎉 |
Motivation and Context
Fixes #5127
Modifications
Added reflect-config.json for ApplyUserAgentInterceptor for s3-transfer-manager module like it is present for ApplyUserAgentInterceptor in dynamodb-enhanced
Testing
I added a reflect-config.json in my project with the same content like in this PR and performed a native-build with
-H:ReflectionConfigurationResources=META-INF/native-image/reflect-config.json
.Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License