Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep port number in SignedUrl #5222

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

davidh44
Copy link
Contributor

Motivation and Context

#5042
In CloudFront distributions, you can optionally specify the port on which a custom origin listens. The public URL will not contain the port number however.

Users may use a URL containing the port number during unit testing. Currently, the returned SignedUrl will strip the port number.

Modifications

Use uri.getAuthority() instead of uri.getHost() when building the SignedUrl to keep the port number

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner May 14, 2024 16:51
@zoewangg
Copy link
Contributor

Can we add a changelog entry?

@davidh44 davidh44 enabled auto-merge (squash) May 14, 2024 20:37
Copy link

sonarcloud bot commented May 14, 2024

@davidh44 davidh44 merged commit 9313708 into master May 14, 2024
17 checks passed
@davidh44 davidh44 deleted the hdavidh/signed-url-keep-port-number branch May 14, 2024 21:52
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
* Keep port number in SignedUrl

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants