Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4990, allow null values in S3 object metadata #5229

Closed
wants to merge 1 commit into from

Conversation

dropofwill
Copy link

Change tests to check keys in any order instead of relying on keySets implicit ordering.

Motivation and Context

Fixes #4990

Modifications

Collect with HashMap instead of built in Java collector which cannot handle nulls.

Testing

Added a test with null keys, fails without my change, passes with it.

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dropofwill dropofwill requested a review from a team as a code owner May 16, 2024 17:43
Change tests to check keys in any order instead of relying on keySets
implicit ordering.
@debora-ito
Copy link
Member

@dropofwill I apologize for the slow turnaround. The issue was fixed in a different PR #5238.

@debora-ito debora-ito closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 ObjectMetadataInterceptor throws NullPointerException if metadata values are null
2 participants