Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ApiName.equals/.hashCode #5302

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

brettkail-wk
Copy link
Contributor

Motivation and Context

Fixes #5292.

Modifications

Implements ApiName.equals and .hashCode in a similar style to CompressionConfiguration.

I think this change qualifies as "non-substantial" for CLA purposes.

Testing

Added ApiNameTest in a similar style to CompressionConfigurationTest.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@brettkail-wk brettkail-wk requested a review from a team as a code owner June 17, 2024 14:02
Copy link
Contributor

@anirudh9391 anirudh9391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. passes CI builds

@anirudh9391 anirudh9391 enabled auto-merge (squash) June 20, 2024 16:59
Copy link

sonarcloud bot commented Jun 20, 2024

@anirudh9391 anirudh9391 merged commit 5066958 into aws:master Jun 21, 2024
11 of 19 checks passed
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
Co-authored-by: Anirudh <anirudh93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiName does not implement equals
2 participants