-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle file upload future completed exceptionally for Java-based TM #5543
Merged
davidh44
merged 8 commits into
master
from
hdavidh/transfer-manager-handle-future-completedExceptionally
Aug 30, 2024
Merged
Handle file upload future completed exceptionally for Java-based TM #5543
davidh44
merged 8 commits into
master
from
hdavidh/transfer-manager-handle-future-completedExceptionally
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sferManager and add logging
joviegas
reviewed
Aug 28, 2024
...r-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/model/CrtFileUpload.java
Show resolved
Hide resolved
joviegas
reviewed
Aug 30, 2024
...r-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/model/CrtFileUpload.java
Outdated
Show resolved
Hide resolved
...nager/src/main/java/software/amazon/awssdk/transfer/s3/internal/model/DefaultFileUpload.java
Outdated
Show resolved
Hide resolved
...r-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/model/CrtFileUpload.java
Show resolved
Hide resolved
...r-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/model/CrtFileUpload.java
Outdated
Show resolved
Hide resolved
joviegas
approved these changes
Aug 30, 2024
Quality Gate failedFailed conditions |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 30, 2024
davidh44
deleted the
hdavidh/transfer-manager-handle-future-completedExceptionally
branch
August 30, 2024 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
During a file upload with the Java-based TransferManager, if an outage occurs and the upload is paused, the resume token is not saved
Modifications
Add a check to see if the upload future was completed exceptionally
Testing
Tested end-to-end locally by shutting off wifi during upload
Tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License