Fixed a bug in AttributeMap, which causes a ConcurrentModificationException… #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudh9391
reviewed
Sep 6, 2024
| @@ -319,6 +319,7 @@ private void internalPut(Key<?> key, Value<?> value) { | |||
| if (oldValue != null) { | |||
| dependencyGraph.valueUpdated(oldValue, value); | |||
| } | |||
|
|
|||
anirudh9391
reviewed
Sep 6, 2024
| dependencyGraph.valueUpdated(v, newValue); | ||
| } | ||
| return newValue; | ||
| Value<?> currentValue = attributes.get(key); |
There was a problem hiding this comment.
Looks good. Is there any way in which we tested this ? If a unit test is difficult, A one-time runnable test that validates these changes would be helpful here. Lmk if its non-trivial to test / validate
There was a problem hiding this comment.
This new behavior is exercised in #5562. Let me see if I can create a standalone test for it, for the purposes of this PR.
…eption when lazy properties depend on lazy properties that depend on any other property. This is achieved by changing a `compute` into a `get` followed by a `put`.
millems
force-pushed
the
millem/endpoint-url-part-1
branch
from
66c9e85 to
9ed97a3
Compare
|
anirudh9391
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when lazy properties depend on lazy properties that depend on any other property.
This is achieved by changing a
computeinto agetfollowed by aput.This code path was not hit before the endpoint URL changes, which are forthcoming. Those changes also add a path that tests this change.