Update ProfileFile to support reading sub-properties. #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub-properties are those nested under another property. E.g. ``` [default] s3 = endpoint_url = foo ``` Before this change, only `s3` would be available, and would contain the raw string underneath the property. After this change, `s3` remains the same, but `foo` can be retrieved through the property `s3.endpoint_url`. This change also adds the property for `endpoint_url` and a convenience setter for profile content strings.
zoewangg
approved these changes
Sep 4, 2024
zoewangg
reviewed
Sep 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Sub-properties are those nested under another property. E.g. ``` [default] s3 = endpoint_url = foo ``` Before this change, only `s3` would be available, and would contain the raw string underneath the property. After this change, `s3` remains the same, but `foo` can be retrieved through the property `s3.endpoint_url`. This change also adds the property for `endpoint_url` and a convenience setter for profile content strings.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-properties are those nested under another property. E.g.
Before this change, only
s3would be available, and would contain the raw string underneath the property. After this change,s3remains the same, butfoocan be retrieved through the propertys3.endpoint_url.This change also adds the property for
endpoint_urland a convenience setter for profile content strings.