Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SDK version to the previous released version automatically for mi… #5561

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 4, 2024

…gration tool

Motivation and Context

Currently, the v2 version used in migration tool is hard coded to 2.27.0. This change sets SDK version to the previous released version automatically for migration tool. upgrade-sdk-dependencies.yml is updated as part of the release process.

Testing

Updated existing tests to bypass tests if the previous released version is not available in maven because it'll cause tests to fail.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner September 4, 2024 22:31
@zoewangg zoewangg force-pushed the zoewang/migrationToolDynamicVersion branch 2 times, most recently from 4c80384 to 0890bfd Compare September 4, 2024 23:15
@@ -1,144 +0,0 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer needed because v1 stopped receiving service updates.

@zoewangg zoewangg force-pushed the zoewang/migrationToolDynamicVersion branch from 0890bfd to 858935e Compare September 4, 2024 23:24
@zoewangg zoewangg force-pushed the zoewang/migrationToolDynamicVersion branch 2 times, most recently from c8463d0 to ab82664 Compare September 9, 2024 16:39
@zoewangg zoewangg added this pull request to the merge queue Sep 9, 2024
@zoewangg zoewangg removed this pull request from the merge queue due to a manual request Sep 9, 2024
@zoewangg zoewangg force-pushed the zoewang/migrationToolDynamicVersion branch from ab82664 to 18eac32 Compare September 9, 2024 20:01
@zoewangg zoewangg enabled auto-merge September 9, 2024 20:01
@zoewangg zoewangg added this pull request to the merge queue Sep 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 9, 2024
@zoewangg zoewangg added this pull request to the merge queue Sep 9, 2024
@zoewangg zoewangg removed this pull request from the merge queue due to a manual request Sep 9, 2024
@zoewangg zoewangg enabled auto-merge September 9, 2024 23:00
@zoewangg zoewangg added this pull request to the merge queue Sep 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 9, 2024
@zoewangg zoewangg added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
@zoewangg zoewangg force-pushed the zoewang/migrationToolDynamicVersion branch from 58e4b49 to 37d3333 Compare September 18, 2024 23:31
@zoewangg zoewangg enabled auto-merge September 18, 2024 23:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit db81c49 Sep 19, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants