Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modified bug issue template to add checkbox to report potential regression. #5572

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ashishdhingra
Copy link
Contributor

Motivation and Context

Label potential-regression would make issue standout in the list and help engineers to handle high severity issues effectively.

Modifications

  • Modified bug issue template to add checkbox to report potential regression.
  • Added GitHub action to add/remove label potential-regression when issue is created/edited.

NOTE:

  • The GitHub action code was ported from CDK repo.
  • The label potential-regression would need to be created manually (we could use color #FF6700 and description Marking this issue as a potential regression to be checked by team member to make it consistent across SDK repos)

Testing

N/A

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@ashishdhingra ashishdhingra requested a review from a team as a code owner September 6, 2024 17:42
Copy link
Member

@debora-ito debora-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check in the regression labeler to see if the repo is aws/aws-sdk-java-v2? This is to prevent the workflow from running in forks (ref: https://github.com/aws/aws-sdk-java-v2/pull/5107/files)

@ashishdhingra ashishdhingra force-pushed the user/ashdhin/IssueTemplateRegressionCheckbox branch from 49b3f76 to 1f258be Compare September 12, 2024 17:34
@ashishdhingra
Copy link
Contributor Author

Can you add a check in the regression labeler to see if the repo is aws/aws-sdk-java-v2? This is to prevent the workflow from running in forks (ref: https://github.com/aws/aws-sdk-java-v2/pull/5107/files)

Done. Please review.

@ashishdhingra ashishdhingra force-pushed the user/ashdhin/IssueTemplateRegressionCheckbox branch from 00a5c74 to 71fad23 Compare September 13, 2024 17:29
Copy link

@ashishdhingra ashishdhingra added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit d72c3d5 Sep 13, 2024
17 checks passed
@ashishdhingra ashishdhingra deleted the user/ashdhin/IssueTemplateRegressionCheckbox branch September 14, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants