Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integeration tests for SQS Automatic Request Batching #5576

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Sep 6, 2024

Motivation and Context

  • Integ test for Automatic Request Batching
  • Integ test is needed to make sure Batching feature is able to handle SQS service real time behaviour when it comes to sending and receieing message

Summary of Testing in RequestBatchManagerSqsIntegrationTest

This test class performs integration testing for AWS SQS batch manager, covering various message sending, receiving, and management scenarios using SQS.

Scenarios Covered:

  1. Basic Message Sending:

    • sendTenMessages: Sends 10 messages to a queue.
    • sendTwentyMessages: Sends 20 messages to a queue.
  2. Batching and Scheduling:

    • scheduleSendFiveMessages: Sends 5 messages in a batch and checks batch processing time.
    • scheduleTwoSendMessageBatches: Sends 10 messages in two batches and checks batch behavior.
  3. Multi-threaded Message Sending:

    • sendMultipleMessagesWithMultiThread: Sends messages using multiple threads and verifies concurrency.
  4. Messages to Different Queues:

    • scheduleFiveMessagesWithEachThreadToDifferentLocations: Sends messages to different queues from multiple threads.
  5. Message Deletion:

    • deleteMessages: Sends and deletes messages, ensuring batch deletion works.
  6. Visibility Timeout Change:

    • changeVisibilityMessages: Changes visibility timeout of messages after sending.
  7. Large Message Handling:

    • sendMessagesWhichCanExceed256KiBCollectively: Sends large messages (256 KiB) and verifies correct handling.
  8. Queue Management:

    • createSendMessageRequestsForDifferentDestinations: Creates multiple queues and sends messages to them.

Key Features:

  • Multi-threading: Concurrent message sending and management.
  • Batching: Focus on batch processing for sending, receiving, and deleting messages.
  • Message Size Limit: Tests sending large messages near the 256 KiB limit.
  • Custom Configurations: Tests custom attributes and system attributes for messages.

Summary of Testing in ResponseBatchManagerSqsIntegrationTest

This test class performs integration testing for AWS SQS response batch manager, focusing on message sending, receiving, and processing via SQS.

Scenarios Covered:

  1. Basic Message Receiving:

    • simpleReceiveMessagesWithDefaultConfiguration: Sends 10 messages and receives them with default batch manager settings. Ensures no message attributes or system attributes are present.
  2. Custom Configuration for Message Receiving:

    • simpleReceiveMessagesWithCustomConfigurations: Tests receiving messages with custom configurations (e.g., wait time, message attributes). Ensures message attributes and system attributes are correctly processed.
  3. Request-Level Max Message and Wait Time Handling:

    • requestLevelMaxMessageAndWaitTimeIsHonoured: Ensures the request-level configurations like maxNumberOfMessages and waitTimeSeconds are respected when receiving and processing messages. Verifies message deletion after receiving each message.

Key Features:

  • Batch Processing: Tests the behavior of batch manager while sending, receiving, and deleting messages.
  • Custom Configurations: Tests custom configurations for receiving messages (e.g., attribute names, system attribute names, wait times).
  • Message Deletion: Ensures proper message deletion after processing.

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner September 6, 2024 23:57
Copy link

sonarqubecloud bot commented Sep 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@joviegas joviegas merged commit caae0c4 into feature/master/sqs-batch-manager Sep 9, 2024
15 of 19 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2024
* Codegenerate BatchManager API under AsyncClient and Initail Interfaces for BatchManager (#5321)

* Codegenerate BatchManager API under AsyncClient and Add empty initial Batchmanager interfaces and Implementations

* Addressed review comments

* Added Internal classes required for BatchManager Implementation

* Revert "Added Internal classes required for BatchManager Implementation"

This reverts commit 318969b.

* Internal classes and RequestBatchManager Impelementation (#5418)

* Added Internal classes required for BatchManager Implementation

* Added Batch Send Implementation

* Handled review comments

* Handled review comments

* Handled review comments

* Made RequestBatchManager class a Abstract class

* Checkstyle issues

* Removed unused methods

* New lines removed

* Made public static to private state for sqsBatch functions

* Constants added

* Sonar cloud issues fixed

* commit to check why test on codebuild

* Increased Timeouts for get

* Added abstract methods

* Handled comments to remove Builders

* Handled comments to take care when batchmanager closed while pending requests

* Handled comments

* Checkstyle issue

* Added Consumer builders args for existing APIs of BatchManager (#5514)

* Receive Batch Manager Implementation (#5488)

* Add Recieve Buffer Queue And its related configuration

* Update ReceiveBatch  manager

* Recieve Batch Manager Implementation

* Receive Batch Manager Implemetation

* Handled review comments

* Checkstyle failure

* Flsky test case fixed

* Flaky test case fixed

* Hamdled review comments

* Handled comments

* Removed ReceiveMessageCompletableFuture

* SdkClosable implemented

* Added ReceiveMessageBatchManager class for completeness

* Checkstyle issues

* Null checks

* Handled comments from Zoe

* Updated the defaults to 50ms same as V1 after surface area review

* Revert "Updated the defaults to 50ms same as V1 after surface area review"

This reverts commit e7d2295.

* Bytes Based batching for SendMessageRequest Batching (#5540)

* Initial changes

* Initial changes 2

* Byte Based batching for SendMessage API

* Byte Based batching for SendMessage API

* Handled comments

* Checkstyle issue

* Add User Agent for Sqs Calls made using Automatic Batching Manager  (#5546)

* Add User Agent for Sqs Calls made using Automatic Batching Manager as hll/abm

* Review comments

* Update comments from  PR 5488 (#5550)

* Update comments of PR 5488

* Update comments from  PR 5488

* Handled surface area review comments (#5563)

* Initial version

* Intermediate changes

* Update after internal poll

* ResponseCOnfiguration construction updated

* RequestOverride configuration check added to Bypass batch manager

* Handled review comments

* Removed TODO since validations are handled in BatchPverrideConfiguration

* Fix issue where the Scheduled Timeout was incorrectly completing the futures with empty messages (#5571)

* Fix issue where the Scheduled Timeout was incorrectly completing the futures with empty messages

* Handled review comments

* Integ test for Automatic Request Batching (#5576)

* feat(sqs): add BatchManager for client-side request batching to Amazon SQS

The new BatchManager allows for simple request batching using client-side buffering, improving cost efficiency and reducing the number of requests sent to Amazon SQS. The client-side buffering supports up to 10 requests per batch and is supported by the SqsAsyncClient. Batched requests, along with receive message polling, help to increase throughput.

* Add check for scheduledExecutor such that it not null when creating SqsAsyncBatchManager (#5582)

* Add check for scheduledExecutor such that it not null when creating SqsAsyncBatchManager

* Update services/sqs/src/test/java/software/amazon/awssdk/services/sqs/batchmanager/SqsAsyncBatchManagerBuilderTest.java

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>

* Update services/sqs/src/test/java/software/amazon/awssdk/services/sqs/batchmanager/SqsAsyncBatchManagerBuilderTest.java

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>

* Update services/sqs/src/test/java/software/amazon/awssdk/services/sqs/batchmanager/SqsAsyncBatchManagerBuilderTest.java

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>

---------

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>

* Updating Timeouts in gets so that we dont wait infinitely

---------

Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
@joviegas joviegas deleted the joviegas/integ_tests branch January 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants