-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x-amzn-query-mode to http header when service has @awsQueryCompatible trait #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd "x-amzn-query-mode" to http header
millems
reviewed
Nov 12, 2024
...protocol/src/main/java/software/amazon/awssdk/protocols/json/BaseAwsJsonProtocolFactory.java
Show resolved
Hide resolved
...a/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshallerBuilder.java
Outdated
Show resolved
Hide resolved
.../aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/AWSQueryModeTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Thank you for the comments! Could you please review it again? |
millems
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add hasAWSQueryCompatible field to the marshaller, The SDKs will send an HTTP header x-amzn-query-mode set to true when a service has the @awsQueryCompatible trait.
Modifications
Add a boolean field hasAWSQueryCompatible to JsonProtocolMarshaller and its builder(default set as false) If it is true then add x-amzn-query-mode to the header of the http request
Testing
I added two testcases to validate SDK sends x-amzn-query-mode header when service has @awsQueryCompatible trait
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License