Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mpuDefaultSplitImpl_partsFailOfRetryableError_shouldFail
test intermittently fails in CI environments following PR #6368 which replaced the directSplittingPublisher
constructor with a builder pattern, which likely changed the threading or timing behavior of when theNonRetryableException
gets thrown versus when WireMock processes and counts the HTTP requests.This seems to cause a race condition in the test where sometimes the test sees the expected single request and sometimes it sees multiple requests before the exception occurs:
or
When testing this locally, I ran a parameterizedTest with 1000 iterations and saw 100% success rate even when running in parallel. This is probably failing in our CI build for some environment specific reasons. As first low effort measure, I added a simple retryer that will retry each parameterized test 3 times before failing.