Skip to content

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 25, 2025

Motivation and Context

This commit adds support for reusing calculated payload checksums over retries in the legacy (i.e. non-SRA) signing codepaths.

Builds on #6441.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the dongie/immutable-checksum-pt3 branch 2 times, most recently from 7da4d9b to f327336 Compare September 25, 2025 20:57
@dagnir dagnir marked this pull request as ready for review September 25, 2025 21:08
@dagnir dagnir requested a review from a team as a code owner September 25, 2025 21:08
@dagnir dagnir force-pushed the dongie/immutable-checksum-pt3 branch from f327336 to 5dc6463 Compare September 25, 2025 21:13
This commit adds support for reusing calculated payload checksums over
retries in the legacy (i.e. non-SRA) signing codepaths.
@dagnir dagnir force-pushed the dongie/immutable-checksum-pt3 branch from 5dc6463 to d7832d8 Compare September 25, 2025 21:44
Copy link
Contributor

@Fred1155 Fred1155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to add integration test to test the retry behavior for reusing the checksum?

@dagnir
Copy link
Contributor Author

dagnir commented Sep 25, 2025

Do we plan to add integration test to test the retry behavior for reusing the checksum?

Good catch! We have mock HTTP client tests from a previous PR, but this is on on SRA. I'll add additional tests for non-SRA.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.7% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dagnir dagnir merged commit 4cb9210 into feature/master/checksum-reuse Sep 26, 2025
29 of 31 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants