Optimizations for EnhancedDocument.toJson() #6446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidh44
added
the
no-api-surface-area-change
|
dagnir
reviewed
Sep 25, 2025
.../java/software/amazon/awssdk/enhanced/dynamodb/internal/document/JsonStringFormatHelper.java
Show resolved
Hide resolved
dagnir
approved these changes
Sep 25, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Provide optimizations for
EnhancedDocument.toJson()Modifications
When escaping characters, check that escaping is actually needed before entering switch flow. Else, skip the switch flow and append the char as-is to the
StringBuilder.If no characters need escaping, return input String as-is without initializing
StringBuilderTesting
Current unit tests for escape characters pass
Screenshots (if appropriate)
Types of changes