Skip to content

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 25, 2025

Motivation and Context

The bundle transitively includes caffeine-2.9.3 via the aws-s3-accessgrants-java-plugin dependency.

Per ben-manes/caffeine#628 caffeine itself does not use Jandex (and removed it in the next version 3.0.0).

Modifications

Testing

# Build the Bundle
mvn clean install -P publishing -pl :bundle -Dgpg.skip=true -DskipTests -Dcheckstyle.skip=true -Dspotbugs.skip=true -am -T0.4C


# Verify the bundle doesn't contain this file
jar -tf aws-sdk-java-bundle-2.34.5-SNAPSHOT.jar | grep -i jandex

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

The bundle transitively includes caffeine-2.9.3 via the
aws-s3-accessgrants-java-plugin dependency.

Per ben-manes/caffeine#628 caffeine itself
does not use Jandex (and removed it in the next version 3.0.0).
@dagnir dagnir marked this pull request as ready for review September 25, 2025 23:16
@dagnir dagnir requested a review from a team as a code owner September 25, 2025 23:16
Copy link

@dagnir dagnir added this pull request to the merge queue Sep 27, 2025
Merged via the queue into master with commit 1295ae2 Sep 27, 2025
36 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants