Skip to content

Check for raw string in extra.raw when searching for quotes #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Check for raw string in extra.raw when searching for quotes #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ea15d
test: misc/single-quote.require
trivikr Nov 12, 2023
f05b99a
Check for raw string in extra.raw
trivikr Nov 12, 2023
5bf31cf
chore: yarn changeset
trivikr Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-seahorses-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"aws-sdk-js-codemod": patch
---

Check for raw string in extra.raw when searching for quotes
3 changes: 3 additions & 0 deletions src/transforms/v2-to-v3/__fixtures__/misc/single-quote.require.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const AWS = require('aws-sdk');

const client = new AWS.DynamoDB();
3 changes: 3 additions & 0 deletions src/transforms/v2-to-v3/__fixtures__/misc/single-quote.require.output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const { DynamoDB } = require('@aws-sdk/client-dynamodb');

const client = new DynamoDB();
2 changes: 1 addition & 1 deletion src/transforms/v2-to-v3/utils/getMostUsedStringLiteralQuote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const getMostUsedStringLiteralQuote = (
if (typeof value === "string") {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore Property 'raw' does not exist on type 'Literal'.
const rawValue = path.node.raw || "";
const rawValue = path.node.raw || path.node.extra?.raw || "";
if (rawValue.startsWith("'")) {
quoteCount[StringLiteralQuoteType.SINGLE]++;
} else if (rawValue.startsWith('"')) {
Expand Down