fix(lib-storage): improve concurrency and abortion management #7322
+101
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6426
Description
This change improves the following aspects of the lib:
abortSignal
instead of anabortController
(still available but deprecated) in order to be more consistent with other APIs. This also allows to useUpload
withAbortSignal.timeout()
Promise.race
would causedone()
to reject as soon as the abort controller is aborted, but would not wait for pending tasks to complete. This prevents user code from properly controlling concurrency. This change also avoidsUpload
from seemingly failing if they are aborted during thePutObjectTaggingCommand
phase, and the upload acutally succeeded (since nothing actually cancelled it).abortController
option was updated to not cause a typing issue when used with globalAbortController
(no longer need to@ts-ignore
).Testing
Not tested.
Additional context
We encountered upload "hangs" in our code, similar to those described in #6426 . While investigating, I encountered several opportunities for improvement, as noted in the Description above.
Checklist
*.integ.spec.ts
).@public
tag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.