Skip to content

Commit

Permalink
updates based on feedback, also maple
Browse files Browse the repository at this point in the history
  • Loading branch information
Sean O'Brien committed Aug 14, 2023
1 parent c151413 commit 40f069b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
3 changes: 0 additions & 3 deletions src/S3/BucketEndpointArnMiddleware.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,6 @@ private function generateAccessPointHost(
$useFips = $this->config['use_fips_endpoint']->isUseFipsEndpoint();
$fipsString = $useFips ? "-fips" : "";

$useFips = $this->config['use_fips_endpoint']->isUseFipsEndpoint();
$fipsString = $useFips ? "-fips" : "";

if ($arn instanceof OutpostsAccessPointArn) {
$host .= '.' . $arn->getOutpostId() . '.s3-outposts';
} else if ($arn instanceof ObjectLambdaAccessPointArn) {
Expand Down
5 changes: 3 additions & 2 deletions src/S3/StreamWrapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,9 @@ public function rename($path_from, $path_to)
// Delete the original object
$this->getClient()->deleteObject([
'Bucket' => $partsFrom['Bucket'],
'Key' => $partsFrom['Key']
] + $options);
'Key' => $partsFrom['Key'],
] + $options);

return true;
});
}
Expand Down
2 changes: 1 addition & 1 deletion tests/MiddlewareTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testWrapsWithRetryMiddleware()
$called = true;
}));
$handler = $list->resolve();
$handler(new Command('foo'), new Request('GET', 'http://example.com'));
$handler(new Command('foo'), new Request('GET', 'http://exmaple.com'));
Promise\Utils::queue()->run();
$this->assertTrue($called);
}
Expand Down

0 comments on commit 40f069b

Please sign in to comment.