chore: skip SubscriptionRequired exceptions (#3012)

aws · Oct 9, 2024 · 4ce4bf0 · 4ce4bf0
1 parent e66ee02
commit 4ce4bf0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/features/smoke/marketplacecommerceanalytics.feature b/features/smoke/marketplacecommerceanalytics.feature
@@ -9,4 +9,4 @@ Feature: AWS Marketplace Commerce Analytics
     | roleNameArn             | fake-arn    |
     | destinationS3BucketName | fake-bucket |
     | snsTopicArn             | fake-arn    |
-    Then I expect the response error code to be "SerializationException"
+    Then I expect the marketplace commerce analytics response error code to be "SerializationException"
diff --git a/tests/Integ/SmokeContext.php b/tests/Integ/SmokeContext.php
@@ -182,15 +182,7 @@ public static function setUpMarketplaceCommerceAnalytics(BeforeFeatureScope $sco
                     'destinationS3BucketName' => 'fake-bucket',
                     'snsTopicArn' => 'fake-arn',
                 ]);
-        } catch (\Exception $e) {
-            // If the test failed because the account has no support subscription,
-            // throw the exception to cause the feature to be skipped.
-            if ($e instanceof AwsException
-                && 'SubscriptionRequiredException' === $e->getAwsErrorCode()
-            ) {
-                throw $e;
-            }
-        }
+        } catch (\Exception $e) {}
     }
 
     /**
@@ -366,6 +358,22 @@ public function iExpectTheResponseErrorCodeToBe($errorCode)
         $this->assertSame($errorCode, $this->error->getAwsErrorCode());
     }
 
+    /**
+     * @Then I expect the marketplace commerce analytics response error code to be :errorCode
+     *
+     * @param string $errorCode
+     */
+    public function iExpectTheMarketplaceCommerceAnalyticsErrorCodeToBe($errorCode)
+    {
+        if ($this->error->getAwsErrorCode() === 'SubscriptionRequiredException') {
+            // For skipping subscription required exceptions
+            $this->assertTrue(true);
+            return;
+        }
+
+        $this->assertSame($errorCode, $this->error->getAwsErrorCode());
+    }
+
     /**
      * @Then I expect the response error message to include:
      *