Skip to content

Commit

Permalink
enhancement: add git secrets scan to CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Sean O'Brien committed Aug 2, 2024
1 parent 33de264 commit d871825
Show file tree
Hide file tree
Showing 2 changed files with 81 additions and 0 deletions.
80 changes: 80 additions & 0 deletions .github/workflows/git-secrets-scan.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
name: Git Secrets Scan

on:
pull_request:
branches:
- master

jobs:
git-secrets-scan:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Set up Git Secrets
run: |
sudo apt-get update
sudo apt-get install -y git
git clone https://github.com/awslabs/git-secrets.git
cd git-secrets
sudo make install
cd ..
git secrets --install
git secrets --register-aws
- name: Fetch previous commit
run: |
git fetch origin +refs/heads/${{ github.base_ref }}:refs/remotes/origin/${{ github.base_ref }}
export DIFF=$(git diff origin/${{ github.base_ref }} HEAD)
echo "${DIFF}" > diff.txt
- name: Filter out skipped patterns
run: |
skippedPrefixes=(
'src/data/s3control/2018-08-20/endpoint-tests-1.json.php'
'tests/DynamoDb/MarshalerTest.php'
'- '
'\[ERROR\]'
'\\n'
'PHP_EOL'
'Possible'
'/usr/local/bin/git-secrets:'
'tests/S3Control'
'tests/Arn'
)
skippedRegexes=(
'/examples-/'
'/UpdateDataSourceRequest\$Credentials/'
'/"AccountId": "123456789012"/'
'/"AccountId": "999999999999"/'
'/123456789012/'
'/999999999999/'
'/"Username": "username"/'
'/"Password": "password"/'
'/RegisterUserResponse\$UserInvitationUrl/'
)
# Filter out lines matching skipped prefixes
for prefix in "${skippedPrefixes[@]}"; do
sed -i "\|${prefix}|d" diff.txt
done
# Filter out lines matching skipped regexes
for regex in "${skippedRegexes[@]}"; do
sed -i -E "${regex}d" diff.txt
done
- name: Run Git Secrets scan on filtered diff
run: |
if [ -s diff.txt ]; then
cat diff.txt | git secrets --scan - 2>&1
status=$?
if [ $status -ne 0 ]; then
exit $status
fi
else
echo "No differences found."
fi
1 change: 1 addition & 0 deletions tests/Credentials/CredentialProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1762,6 +1762,7 @@ function ($c, $r) use ($result) {

public function testEnsuresAssumeRoleWebIdentityProfileIsPresent()
{
$accountId = '999999999999';
$this->expectExceptionMessage("Unknown profile: fooProfile");
$this->expectException(\Aws\Exception\CredentialsException::class);
$dir = $this->clearEnv();
Expand Down

0 comments on commit d871825

Please sign in to comment.