feat: add option to make IMDSv1 fallback optional #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamRemis
reviewed
Nov 2, 2023
stobrien89
requested changes
Nov 2, 2023
yenfryherrerafeliz
force-pushed
the
impl_imdsv1_as_optional
branch
from
c6082bc
to
9e2afce
Compare
stobrien89
requested changes
Nov 7, 2023
yenfryherrerafeliz
force-pushed
the
impl_imdsv1_as_optional
branch
from
9e2afce
to
5f2924a
Compare
stobrien89
approved these changes
Nov 10, 2023
Right now IMDSv1 fallback is enabled by default, but this implementation allows customer to decided whether or not they want this behavior when using the InstanceProfileProvider. Here is how this can be set: - Explicit configuration: $provider = new InstanceProfileProvider(['ec2_metadata_v1_disabled' => true|false]); - Environment variable: AWS_EC2_METADATA_V1_DISABLED set to true or false - Config file. Example: [default] ec2_metadata_v1_disabled=true|false
yenfryherrerafeliz
force-pushed
the
impl_imdsv1_as_optional
branch
from
5f2924a
to
9e2aaa1
Compare
updating namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now IMDSv1 fallback is enabled by default, but this implementation allows customer to decided whether or not they want this behavior when using the InstanceProfileProvider. Here is how this can be set:
Description of changes:
Add a function that resolves for whether or not we should fallback to IMDSv1.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.