Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for psr/simple-cache v2 and v3 #2838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmn-eloha-jouny
Copy link

Issue #, if available:
I don't think i need to create an issue for this.

Description of changes:
I need this change when peer-dependencies require different version of the psr/simple-cache package.
In my case, the package mobiledetect/mobiledetectlib require version 3. Since these versions do not change public interface (only type safety was added) i think it is safe to allow this.

@rmn-eloha-jouny rmn-eloha-jouny changed the title Allow multiple versions of psr/simple-cache Add support for psr/simple-cache v2 and v3 Nov 28, 2023
@rmn-eloha-jouny
Copy link
Author

Any chance to get this PR reviewed ?

@Timic3
Copy link

Timic3 commented Sep 12, 2024

We are also blocked by this issue. Can this get merged any time soon?

@stobrien89
Copy link
Member

@rmn-eloha-jouny,

Thanks for the contribution. Can you add a changelog entry by creating a json file (e.g. simple-cache.json) in .changes/nextrelease? you can label this as an enhancement. It should follow the format below (you can feel free to copy/paste this).

[
  {
    "type": "enhancement",
    "category": "",
    "description": "Adds support for psr/simple-cache v2 and v3"
  }
]

@rmn-eloha-jouny
Copy link
Author

Thank you @stobrien89. I've added the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants