bugfix: iso8601 timestamp parsing #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
force-pushed
the
iso-8601-fix
branch
from
baa6f77
to
d821673
Compare
yenfryherrerafeliz
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #2967
Fixes issue with parsing iso8601 timestamps with nanosecond precision, as this is not supported on PHP versions 8.0.9 and below. When parsing iso8601 timestamps, a version check and regex pattern are used to evaluate whether or not the timestamp should be modified. If so, the timestamp is reduced to microsecond precision prior to instantiating a new
DateTimeResultobject.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.