-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account id endpoint support #2976
feat: account id endpoint support #2976
Commits on Feb 23, 2024
-
feat: account id endpoint resolution support
This change add account_id as part of the identity resolution, from the different credentials provider. It also validates whether an account should have been resolved based on the configure option account_id_endpoint_mode. The way this is done is by using lazy resolvers. We wrap the credentials provider into a custom lazy resolver that will avoid resolving credentials more than once, which means that in that credentials lazy resolver the value will be resolved once, and it will be returned everytime the credentials provider is consumed/invoked. For accountId builts-in, we also use a lazy resolver which holds the validation for wheter account_id value should have been resolved as part of the resolved identity. This accountId built-ins lazy resolver is resolved from endpoint resolution.
Configuration menu - View commit details
-
Copy full SHA for 2ea2504 - Browse repository at this point
Copy the full SHA 2ea2504View commit details
Commits on Feb 26, 2024
-
fix: force credentials resolution and resolve conf
For resolving credentials just once per request, and no just once per client initialization, we are adding a middleware that will call forceRefresh method from the CredentialsLazyResolver implementation, and since this middleware will be executed in every request then, the credentials will be fresh per request. We are also fixing here how account_id_endpoint_mode configuration is being resolved.
Configuration menu - View commit details
-
Copy full SHA for 319169a - Browse repository at this point
Copy the full SHA 319169aView commit details
Commits on Feb 29, 2024
-
fix: address PR feedback for accountId support
In this change we add AccountId resolution for when AccountId is part of the rulesetParameters and accountIdEndpointMode is not disabled, in EndpointV2Middleware. If AccountId should be resolved then, we will resolve the credentialsProvider, which will resolve an identity from which we will extract the accountId, and if an accountId is not present in that resolved identity then, we will log a warning if accountIdEndpointMode is set to preferred or throw an exception if accountIdEndpointMode is required. Another part of this change is, that if we get up to the point of resolving the credentials provider then, we inject the resolved identity into $command['@context'] as the property 'resolved_identity'. We do this for trying to avoid having to resolve credentials more than once per request.
Configuration menu - View commit details
-
Copy full SHA for afa8033 - Browse repository at this point
Copy the full SHA afa8033View commit details
Commits on Mar 5, 2024
-
chore: address PR feedback and include tests
Addresses feedback for conditionally calling the method resolvingAccountId based on if the parameter is present in the rulesset of the endpoint provider. Include tests coverage for AssumeRoleCredentialProvider, AssumeRoleWithWebIdentityCredentialProvider, process, shared files, and credentials from environment.
Configuration menu - View commit details
-
Copy full SHA for 9d5f0c8 - Browse repository at this point
Copy the full SHA 9d5f0c8View commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6dab51 - Browse repository at this point
Copy the full SHA c6dab51View commit details
Commits on Mar 19, 2024
-
feat: remove account id endpoint mode validations
The validation of whether account_id should be resolved or not is going to be done by the ruleset, and therefore the validation logic around this needs to be removed.
Configuration menu - View commit details
-
Copy full SHA for b0ff4ad - Browse repository at this point
Copy the full SHA b0ff4adView commit details
Commits on Mar 20, 2024
-
- Move test cases into a valid existent class. In this case the tests in SourceAccountIdEndpointTest were moved to StsClient class. - Create test for InstanceProfileProvider - Create test for EcsCredentialProvider
Configuration menu - View commit details
-
Copy full SHA for 5204f33 - Browse repository at this point
Copy the full SHA 5204f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a9991 - Browse repository at this point
Copy the full SHA 24a9991View commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f041393 - Browse repository at this point
Copy the full SHA f041393View commit details -
chore: remove null coalescing operator
Remove null coalescing operator from the CredentialProvider class in order to prevent Docs Build to fail.
Configuration menu - View commit details
-
Copy full SHA for 0b71c81 - Browse repository at this point
Copy the full SHA 0b71c81View commit details
Commits on Jun 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2c7589d - Browse repository at this point
Copy the full SHA 2c7589dView commit details
Commits on Jul 3, 2024
-
test: modify endpoint test cases
Make endpoint test cases compatible with account_id endpoint mode.
Configuration menu - View commit details
-
Copy full SHA for 6a8b3e3 - Browse repository at this point
Copy the full SHA 6a8b3e3View commit details
Commits on Jul 29, 2024
-
chore: resolve merge conflicts
Resolved merge conflicts when merging master into feat_account_id_endpoint_support branch.
Configuration menu - View commit details
-
Copy full SHA for 32aead4 - Browse repository at this point
Copy the full SHA 32aead4View commit details
Commits on Aug 5, 2024
-
chore: make test accounts to be dummy
Update test account values to be in compliant with our git-secrets checks. We can use either dummy values, such as `foo`, or the fixed values `123456789012` or `999999999999`.
Configuration menu - View commit details
-
Copy full SHA for 30ab4e1 - Browse repository at this point
Copy the full SHA 30ab4e1View commit details