fix: error matcher on booleans #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Just one minor change requested. Thanks @yenfryherrerafeliz!
tests/WaiterTest.php
Outdated
| * | ||
| * @return void | ||
| */ | ||
| public function testWaiterMatcherExpectNoError(): void { |
There was a problem hiding this comment.
brace needs to go down to a new line
|
We should also publish a changelog entry for this one |
yenfryherrerafeliz
force-pushed
the
fix_waiter_error_boolean
branch
2 times, most recently
from
fbfa6b7
to
4b33693
Compare
When the expected value from acceptor is a boolean then, the matcher should: - if expected is true then an error should be matched. - if expected is false then no error should has been occurred.
yenfryherrerafeliz
force-pushed
the
fix_waiter_error_boolean
branch
from
4b33693
to
50bafeb
Compare
stobrien89
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the expected value from acceptor is a boolean then, the matcher should:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.