Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php deprecated log error level #2989

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

ishiguro-junya
Copy link
Contributor

Issue #, if available: #2952

Description of changes:
Fix the log level.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ishiguro-junya ishiguro-junya changed the title fix: log error level (#2952) fix: php deprecated log error level Aug 23, 2024
@stobrien89
Copy link
Member

stobrien89 commented Aug 23, 2024

Hi @ishiguro-junya,

Thanks for the contribution! The decision to use E_USER_WARNING over E_USER_DEPRECATED was actually due to the fact that customers using versions in the affected deprecation ranges will still be able to continue using their current SDK versions; they just won't receive updates after we change the required PHP language level. We're going to keep the warning level at E_USER_WARNING, since this is not a deprecation in the sense of "code stops working".

@stobrien89 stobrien89 closed this Aug 23, 2024
@stobrien89 stobrien89 reopened this Aug 23, 2024
@stobrien89
Copy link
Member

Disregard my first comment. It was posted before I read the discussion in #2952. I'm fine with changing this.

@stobrien89
Copy link
Member

Thanks again @ishiguro-junya!

@stobrien89 stobrien89 merged commit dc2e712 into aws:master Aug 26, 2024
19 checks passed
@ishiguro-junya ishiguro-junya deleted the fix-log-error-level branch August 28, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants