bugfix: LocationConstraint middleware #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
force-pushed
the
fix-s3-location-middleware
branch
2 times, most recently
from
c3ebdfd
to
d52a758
Compare
yenfryherrerafeliz
requested changes
Sep 25, 2024
stobrien89
force-pushed
the
fix-s3-location-middleware
branch
from
d52a758
to
5f8cff1
Compare
yenfryherrerafeliz
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates middleware to skip directory buckets (
LocationRestraintis not supported) and fixes a long-running bug where the middleware would override previously configuredCreateBucketConfiguration. See https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#AmazonS3-CreateBucket-request-LocationConstraintBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.