Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kubernetes-sigs/image-builder and Bottlerocket versions to latest release #3627

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Bump kubernetes-sigs/image-builder and Bottlerocket versions to latest release #3627

merged 2 commits into from
Sep 20, 2024

Conversation

eks-distro-pr-bot
Copy link
Contributor

@eks-distro-pr-bot eks-distro-pr-bot commented Aug 14, 2024 •
edited by abhay-krishna
Loading

This PR bumps kubernetes-sigs/image-builder and Bottlerocket releases to the latest Git revision.

Compare changes for image-builder
Release notes for image-builder

Compare changes for Bottlerocket
Release notes for Bottlerocket

/hold
/area dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2024
@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 1a64984 to a231df2 Compare August 16, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from a231df2 to e4e2598 Compare August 17, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch 2 times, most recently from 4ade713 to 7613e85 Compare August 19, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 7613e85 to f394c7c Compare August 20, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from f394c7c to 5347e44 Compare August 21, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 5347e44 to 51a992a Compare August 22, 2024 08:06
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 51a992a to 4556698 Compare August 23, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 4556698 to 05d5ac7 Compare August 24, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 05d5ac7 to 1417afb Compare August 25, 2024 08:05
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 1417afb to 8ba4e80 Compare August 26, 2024 08:05
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete!

Failed patch details

Only 1/9 patches were applied!
Patch failed at 0002 EKS-D support and changes
The following files in the above patch did not apply successfully:
images/capi/packer/config/kubernetes.json

The project being upgraded in this pull request needs changes to patches that cannot be handled automatically. A developer will need to regenerate the patches locally and update the pull request. In addition to patches, the checksums and attribution file(s) corresponding to the project will need to be updated.

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 8ba4e80 to 5551973 Compare August 27, 2024 08:08
abhay-krishna
abhay-krishna reviewed Sep 19, 2024
View reviewed changes
projects/kubernetes-sigs/image-builder/patches/0004-Ubuntu-22.04-support-and-improvements.patch
@@ -64,86 +59,6 @@ index 143c83999..152d33da6 100644
validate-raw-rhel-8: ## Validates RHEL 8 RAW image packer config
validate-raw-all: $(RAW_VALIDATE_TARGETS) ## Validates all RAW Packer config

diff --git a/images/capi/packer/ova/ubuntu-2204-efi.json b/images/capi/packer/ova/ubuntu-2204-efi.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patches are getting removed as this change has already been upstreamed.

@abhay-krishna abhay-krishna force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 3385cbb to 3ac4b48 Compare September 19, 2024 22:14
@abhay-krishna abhay-krishna force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 3ac4b48 to 4730cb0 Compare September 19, 2024 22:38
@sp1999
Copy link
Member

sp1999 commented Sep 19, 2024

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member

/hold

@abhay-krishna abhay-krishna force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 4730cb0 to 719ef55 Compare September 19, 2024 23:08
@abhay-krishna abhay-krishna force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 719ef55 to 8592e52 Compare September 19, 2024 23:16
@sp1999
Copy link
Member

sp1999 commented Sep 19, 2024

/lgtm

@abhay-krishna abhay-krishna force-pushed the update-kubernetes-sigs-image-builder-and-bottlerocket-main branch from 8592e52 to 861d947 Compare September 19, 2024 23:51
@sp1999
Copy link
Member

sp1999 commented Sep 19, 2024

/lgtm

@abhay-krishna
Copy link
Member

/unhold

@eks-distro-bot eks-distro-bot merged commit 3e45382 into aws:main Sep 20, 2024
7 checks passed
@abhay-krishna abhay-krishna mentioned this pull request Sep 23, 2024
Merged
@rahulbabu95 rahulbabu95 mentioned this pull request Sep 23, 2024
Closed
@abhay-krishna abhay-krishna mentioned this pull request Sep 23, 2024
Merged
@sp1999 sp1999 mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhay-krishna abhay-krishna abhay-krishna left review comments

@sp1999 sp1999 sp1999 left review comments

Assignees

@sp1999 sp1999

Labels
approved area/dependencies lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eks-distro-pr-bot @eks-distro-bot @abhay-krishna @sp1999