RolesAnywhere-4976: Fix failures when module.GetAttributeValue modifies #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the size of the slice parameter * The previous code would reuse slices of type []*pkcs11.Attribute when attempting to find the values of attributes associated with objects in PKCS#11. * The current version will reassign the entire slice to the variable used in the call to module.GetAttributeValue. This prevents potential index out of bounds accesses when assigning to individual elements in the slice (which could've been modified by the previous module.GetAttributeValue call).
rlalcorn
reviewed
Nov 8, 2023
| @@ -286,13 +286,17 @@ func getCertsInSession(module *pkcs11.Ctx, slotId uint, session pkcs11.SessionHa | |||
| // Fetch the CKA_ID and CKA_LABEL of the matching cert(s), so | |||
| // that they can be used later when hunting for the matching | |||
| // key. | |||
| crtAttributes[0] = pkcs11.NewAttribute(pkcs11.CKA_ID, 0) | |||
| crtAttributes = []*pkcs11.Attribute{ | |||
There was a problem hiding this comment.
What's the implication for memory? I suspect that it's really minor, but I don't know the Go memory model well enough.
There was a problem hiding this comment.
Yeah, I think it's minor. The object that gets lost through the assignment here (since it can no longer be referenced later in the code) should be garbage collected later on.
rlalcorn
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous code would reuse slices of type
[]*pkcs11.Attributewhen attempting to find the values of attributes associated with objects in PKCS#11.The current version will reassign the entire slice to the variable used in the call to module.GetAttributeValue. This prevents potential index out of bounds accesses when assigning to individual elements in the slice (which could've been modified by the previous module.GetAttributeValue call).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.