feat(serve): Add configurable TTL to serve responses #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13ajay
approved these changes
Aug 16, 2024
|
Ah, it also occurs to me that brief documentation on this flag would be good to add in the README. If you have time to make these changes, feel free to add it in yourself. Otherwise, I can make the changes later. |
For containerized environments, a TTL of 1 will prevent processes in other network namespaces from being able to reach the host level metadata. This matches EC2's IMDSv2 behavior for credential responses. Signed-off-by: Micah Hausler <mhausler@amazon.com>
micahhausler
force-pushed
the
serve-ttl
branch
from
11dc88e
to
f57164f
Compare
Done! |
|
Thanks for your contribution - merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
For containerized environments, a TTL of 1 will prevent processes in other network namespaces from being able to reach the host level metadata. This matches EC2's IMDSv2 behavior for credential responses. The default value of 64 leaves existing behavior unchanged