Skip to content

Commit

Permalink
refactor nproc_per_node for backwards compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
brunopistone committed Jan 15, 2025
1 parent adcc38e commit 00eb637
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions src/sagemaker/remote_function/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -1081,8 +1081,7 @@ def _prepare_and_upload_runtime_scripts(

if nproc_per_node is not None and nproc_per_node > 0:
entry_point_script = entry_point_script.replace(
"$SM_NPROC_PER_NODE",
str(nproc_per_node)
"$SM_NPROC_PER_NODE", str(nproc_per_node)
)

with open(entrypoint_script_path, "w", newline="\n") as file:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,7 @@ def test_remote_decorator_fields_consistency(get_execution_role, session):
"max_wait_time_in_seconds",
"custom_file_filter",
"use_torchrun",
"nproc_per_node",
}

job_settings = _JobSettings(
Expand Down

0 comments on commit 00eb637

Please sign in to comment.