Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ValueError when updating a data quality monitoring schedule #5002

Merged
merged 7 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sagemaker/model_monitor/model_monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -2413,7 +2413,12 @@ def _update_data_quality_monitoring_schedule(
)
self.sagemaker_session.sagemaker_client.create_data_quality_job_definition(**request_dict)
try:
self._update_monitoring_schedule(new_job_definition_name, schedule_cron_expression)
self._update_monitoring_schedule(
job_definition_name=new_job_definition_name,
schedule_cron_expression=schedule_cron_expression,
data_analysis_start_time=data_analysis_start_time,
data_analysis_end_time=data_analysis_end_time,
)
self.job_definition_name = new_job_definition_name
if role is not None:
self.role = role
Expand Down
31 changes: 31 additions & 0 deletions tests/unit/sagemaker/monitor/test_model_monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
LINFINITY_METHOD = "LInfinity"

CRON_DAILY = CronExpressionGenerator.daily()
CRON_NOW = CronExpressionGenerator.now()
BASELINING_JOB_NAME = "baselining-job"
BASELINE_DATASET_PATH = "/my/local/path/baseline.csv"
PREPROCESSOR_PATH = "/my/local/path/preprocessor.py"
Expand Down Expand Up @@ -1136,6 +1137,36 @@ def _test_data_quality_monitor_update_schedule(data_quality_monitor, sagemaker_s
sagemaker_session.sagemaker_client.delete_data_quality_job_definition.assert_not_called()
sagemaker_session.sagemaker_client.create_data_quality_job_definition.assert_not_called()

# update schedule
sagemaker_session.describe_monitoring_schedule = MagicMock()
sagemaker_session.sagemaker_client.describe_data_quality_job_definition = MagicMock()
sagemaker_session.sagemaker_client.create_data_quality_job_definition = MagicMock()

# Test updating monitoring schedule with schedule_cron_expression set to NOW
sagemaker_session.sagemaker_client.update_monitoring_schedule = Mock()
data_quality_monitor.update_monitoring_schedule(
data_analysis_start_time="-PT24H",
data_analysis_end_time="-PT0H",
schedule_cron_expression=CRON_NOW,
)

sagemaker_session.sagemaker_client.update_monitoring_schedule.assert_called_once_with(
MonitoringScheduleName=data_quality_monitor.monitoring_schedule_name,
MonitoringScheduleConfig={
"MonitoringJobDefinitionName": data_quality_monitor.job_definition_name,
"MonitoringType": DefaultModelMonitor.monitoring_type(),
"ScheduleConfig": {
"ScheduleExpression": CRON_NOW,
"DataAnalysisStartTime": "-PT24H",
"DataAnalysisEndTime": "-PT0H",
},
},
)

# A new data quality job definition should be created
sagemaker_session.sagemaker_client.describe_data_quality_job_definition.assert_called_once()
sagemaker_session.sagemaker_client.create_data_quality_job_definition.assert_called_once()

# update one property of job definition
time.sleep(
0.001
Expand Down