-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Allow telemetry only in supported regions #5009
Conversation
logger.debug( | ||
"Region not found in supported regions. Telemetry request will not be emitted." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets change to logger.warning
else: # telemetry will be sent to us-west-2 if no session available | ||
region = DEFAULT_AWS_REGION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this redundant? This condition is already covered in _get_region_or_default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, _get_region_or_default
covers the condition where session is available but the region
value is not allocated.
The else part takes care of the condition when session
details are not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we are assigning the same thing in 2 different places which is something we can simplify.
By removing the if session condition here in line195 and handling everything within _get_region_or_default
If session is None , it will automatically raise an Exception and will get assigned the default value in L#278.
Issue #, if available:
There is a security vulnerability with the current telemetry setup where the AWS control through unclaimed S3-buckets
Description of changes:
Testing done:
yes, added unit tests for the code change and tested it.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.