-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI enhancements: Code linter, PR description, speed up #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the linter job will fail for this PR and that's expected. Once #262 is merged, this is expected to pass. |
stefankiesz
reviewed
Nov 4, 2024
unicornss
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work on improving the CI.
Apply linting
Fix unit test when log level env variable is not set
stefankiesz
requested changes
Nov 4, 2024
I'll adjust the names of each case to be more concise. It will now be in the format: |
stefankiesz
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
What was changed?
Summary of Changes: This pull request introduces several enhancements to the Continuous Integration (CI) pipeline, focusing on efficiency, speed, and developer experience.
Detailed Changes:
make
's parallel feature to accelerate build processes.Performance improvement:
Before (note some of the jobs fail in under 30s, those are due to failures):
After:
*
to be used in the PR description.tst/
directory (in addition to the currentsrc/
directory)If it passes, you will see the success message in the run summary.
If it fails, you will see a list of files that are not formatted correctly.
Attached to the summary, a patch file is included that you can apply the changes. It also uploads the full corrected file(s) that need formatting.
You can check the example here: https://github.com/awslabs/amazon-kinesis-video-streams-pic/actions/runs/11624707897
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.