Pr 323 #422
Merged
Pr 323 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-kinesis-video-streams-producer-c into PR-323
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
- Coverage 62.83% 62.67% -0.17%
===========================================
Files 32 32
Lines 4599 4614 +15
===========================================
+ Hits 2890 2892 +2
- Misses 1709 1722 +13 ☔ View full report in Codecov by Sentry. |
disa6302
approved these changes
Dec 6, 2023
sirknightj
reviewed
Dec 6, 2023
| @@ -117,6 +118,12 @@ STATUS signAwsRequestInfo(PRequestInfo pRequestInfo) | |||
|
|
|||
| CHK(pRequestInfo != NULL && pRequestInfo->pAwsCredentials != NULL, STATUS_NULL_ARG); | |||
|
|
|||
| // signAwsRequestInfo is a public api function, if service is not specified default to "kinesisvideo" so no breaking changes are introduced to the | |||
| // api | |||
| if (pRequestInfo->service[0] == L'\0') { | |||
There was a problem hiding this comment.
Minor but we can use IS_EMPTY_STRING instead.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#323
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.