v1.5.3 Release #454
Merged
v1.5.3 Release #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're using mbedtls instead of ssl we need to actually link against it when building kvsCommonLws, it is done properly for common curl, but was incorrect for Lws path
version bump
stefankiesz
reviewed
Sep 12, 2024
stefankiesz
previously approved these changes
Sep 12, 2024
unicornss
previously approved these changes
Sep 28, 2024
* Update CMakeLists.txt * install pkgconfiglite windows ci * Revert "Update CMakeLists.txt" This reverts commit f4caee0. * Switch GCC to gcc-14 of Mac CI * Switch to GCC 12 for Mac CI * Try mac os 11 * Update ci.yml * Update ci.yml * latest runners * Fix typo * Uncomment the other tests * Comment back out the sanitizers
stefankiesz
dismissed stale reviews from unicornss and themself
via
b32da5d
stefankiesz
previously approved these changes
Sep 28, 2024
unicornss
previously approved these changes
Sep 28, 2024
stefankiesz
dismissed stale reviews from unicornss and themself
via
b4c82bd
* Update runner versions * Run CI on this branch * Update ci.yml * Don't downgrade Xcode to 15.2 * Update ci.yml
stefankiesz
changed the title
sirknightj
approved these changes
Oct 1, 2024
stefankiesz
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Changes
CI Changes
Issue #, if available: n/a
What was changed?
target_link_libraries now actually links mbedtls
Why was it changed?
previously we were not correctly linking mbedtls
How was it changed?
By adding the missing mbedtls library in the target_link_libraries step
What testing was done for the changes?
Tested with and without change, making the change resolved the issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.