Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the runner images & fix the CI #462

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Bump the runner images & fix the CI #462

merged 8 commits into from
Nov 20, 2024

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Nov 18, 2024

Issue #, if available:

  • N/A

What was changed?

  • Bump the runner images in the GitHub actions configuration file.
  • Building with LWS, it was previously working fine on Clang 11. Encountered build issues with the LWS version (3.2.3) on Clang 14, so disable WERROR on the dependency. The GitHub Ubuntu 20 runner (with CC=clang) uses Clang 11 by default, but the latest uses Clang 14 by default.
[  8%] Building C object CMakeFiles/websockets_shared.dir/lib/core/libwebsockets.c.o
[ 10%] Building C object CMakeFiles/websockets_shared.dir/lib/core/logs.c.o
[ 11%] Building C object CMakeFiles/websockets_shared.dir/lib/misc/base64-decode.c.o
/home/runner/work/amazon-kinesis-video-streams-producer-c/amazon-kinesis-video-streams-producer-c/open-source/libwebsockets/build/src/project_libwebsockets/lib/misc/base64-decode.c:58:6: error: variable 'line' set but not used [-Werror,-Wunused-but-set-variable]
        int line = 0;
            ^
1 error generated.
gmake[5]: *** [CMakeFiles/websockets_shared.dir/build.make:163: CMakeFiles/websockets_shared.dir/lib/misc/base64-decode.c.o] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:90: CMakeFiles/websockets_shared.dir/all] Error 2
gmake[3]: *** [Makefile:156: all] Error 2
gmake[2]: *** [CMakeFiles/project_libwebsockets.dir/build.make:87: build/src/project_libwebsockets-stamp/project_libwebsockets-build] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/project_libwebsockets.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2
CMake Error at CMake/Utilities.cmake:93 (message):
  CMake step for libwebsockets failed: 2
Call Stack (most recent call first):
  CMakeLists.txt:109 (build_dependency)


-- Configuring incomplete, errors occurred!

Why was it changed?

How was it changed?

  • See the files changed tab to see which configuration lines were changed.

What testing was done for the changes?

  • CI should pass.
  • Since only the CI was updated, testing on GitHub actions is sufficient.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj added the ci label Nov 18, 2024
@sirknightj sirknightj changed the base branch from master to develop November 18, 2024 18:23
@sirknightj sirknightj changed the title Bump the runner images Bump the runner images & fix the CI Nov 19, 2024
@sirknightj sirknightj merged commit 63d63e5 into develop Nov 20, 2024
20 checks passed
@sirknightj sirknightj deleted the repair-ci branch November 20, 2024 02:50
sirknightj added a commit that referenced this pull request Nov 22, 2024
* Bump the runner images & fix the CI (#462)

* Bump the runner images

* Bump configure-aws-credentials to v4.

* Downgrade to clang 11

* Sanitzer options

* Go back to clang 14. Turn off warnings as error for libwebsockets

* ON -> 1

* Wno-error via CFLAGS

* Pass C_FLAGS directly

* Bump PIC version and small stack size test (#461)

* Bump PIC and small stack size test

* Bump configure-aws-creds to v4

* Move AWS credentials to after build

* Add permissions

* Cd build

* Use preinstalled toolchain

* Check for seg fault message

* Check exit code

* Update user agent from 1.5.3 to 1.5.4 (#463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants