Add Support for Static Producer to Shared kvssink Builds
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to the kvssink .so with static linkage to cproducer (#1179) Producer Cpp PR.
What was changed?
CURL_POSITION_INDEPENDENT_CODECMake flag to this Producer C library to allow for building a static Curl library with a sharedkvssinklibrary.Why was it changed?
CMAKE_POSITION_INDEPENDENT_CODEnor set-fPIC, so this must be set when building it statically to be consumed by a shared library.How was it changed?
CURL_POSITION_INDEPENDENT_CODEflag from Producer C CMakeLists to Curl CMakeLists to set theCMAKE_POSITION_INDEPENDENT_CODEflag.What testing was done for the changes?
Tested the
kvssinkbuild locally on Ubuntu and added a CI job for it.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.