Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
pConnectionListener->receiveDataRoutine
toINVALID_TID_VALUE
.RollingBuffer
lastIndex
race.Why was it changed?
How was it changed?
receiveDataRoutine
toINVALID_TID_VALUE
wheneverTHREAD_JOIN
is called on its thread. This was done for theIS_VALID_TID_VALUE
check to actually be able to check for whetherTHREAD_JOIN
was already called on the thread.pRollingBuffer->lastIndex
within thepRollingBuffer->lock
.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.