Skip to content

Release 1.7.2 of the Amazon Kinesis Video WebRTC C SDK
Compare
Choose a tag to compare
@jdelapla jdelapla released this 21 Feb 21:19
· 14 commits to master since this release
v1.7.2
2dff44f
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Release tagged at : 2dff44f

Bug Fixes:

  • Fixed an issue where connected sockets were not sending pings

Details about Bug:

Between v3.x.x and v4.x.x the LWS changed the struct that managed the retry policy.
In LWS v4.2.0-.2 there is a bug in the create LWS context function. It checks only if ping is passed in, and then assigns both ping and hangup passed in values. Hangup can be undefined in this case

1045     context->default_retry.secs_since_valid_ping = 300;        //defaults
1046     context->default_retry.secs_since_valid_hangup = 310;
1047     
1048     if (info->retry_and_idle_policy &&
1049         info->retry_and_idle_policy->secs_since_valid_ping) {  //check for ping value to be non-zero.
1050         context->default_retry.secs_since_valid_ping =
1051                 info->retry_and_idle_policy->secs_since_valid_ping;
1052         context->default_retry.secs_since_valid_hangup =
1053                 info->retry_and_idle_policy->secs_since_valid_hangup;  //this is the passed in value of hangup, which could have been unassigned
1054     }

We need to pass in a hangup value greater than the ping value, or the pings will not occur.

Producer C version:

v1.2.X (unreleased at this time) - c7fce9e06021452ff3c42dc70c8360606b22ad53

Assets 2
Loading