Pickup latest release from cJSON #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 52 52
Lines 5641 5641
=======================================
Hits 4639 4639
Misses 1002 1002
☔ View full report in Codecov by Sentry. |
TingDaoK
changed the title
waahm7
approved these changes
Jul 26, 2023
waahm7
reviewed
Jul 26, 2023
include/aws/common/external/cJSON.h
Outdated
| /* helper for the cJSON_SetNumberValue macro */ | ||
| CJSON_PUBLIC(double) cJSON_SetNumberHelper(cJSON *object, double number); | ||
| #define cJSON_SetNumberValue(object, number) ((object != NULL) ? cJSON_SetNumberHelper(object, (double)number) : (number)) //NOLINT | ||
| #define cJSON_SetNumberValue(object, number) (((object) != NULL) ? cJSON_SetNumberHelper((object), (double)(number)) : (number)) |
There was a problem hiding this comment.
Brackets arount object seems redundant 🤔 Ignore if there is a reason for those
Suggested change
| #define cJSON_SetNumberValue(object, number) (((object) != NULL) ? cJSON_SetNumberHelper((object), (double)(number)) : (number)) | |
| #define cJSON_SetNumberValue(object, number) ((object != NULL) ? cJSON_SetNumberHelper(object, (double)(number)) : (number)) |
There was a problem hiding this comment.
Saw the lint errors, we should probably just disable lint on these files.
| @@ -28,10 +28,10 @@ THE SOFTWARE. | |||
| * (3) Remove cJSON_GetErrorPtr and global_error as they are not thread-safe. | |||
| */ | |||
|
|
|||
| /* clang-format off */ | |||
| /* NOLINTBEGIN */ | |||
|
|
|||
There was a problem hiding this comment.
why are we reenabling clang format? if we disabling tidy, we should disable format as well
There was a problem hiding this comment.
there is a .clang-format config that disabled the format already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Pick up change from https://github.com/DaveGamble/cJSON/releases/tag/v1.7.16
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.