Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum stack size to at least 1MB #1139

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Bump the minimum stack size to at least 1MB #1139

merged 9 commits into from
Jul 24, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jul 23, 2024

Issue #, if available:
awslabs/aws-crt-java#737

Description of changes:
Bump the minimum thread stack size to 1MB. Other Platforms have the following values

  • Windows: 1MB
  • GLIBC: 2MB - 8MB
  • Musl 128KB (Used to be 80KB)
  • Mac: 8MB for primary threads and 512KB for secondary threads.

I have tested a 1MB limit with the original customer issue sample, and it works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.40%. Comparing base (852f8ce) to head (54de546).

Files Patch % Lines
source/posix/thread.c 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   83.44%   83.40%   -0.04%     
==========================================
  Files          57       57              
  Lines        5985     5995      +10     
==========================================
+ Hits         4994     5000       +6     
- Misses        991      995       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 changed the title WIP | Bump the minimum stack size to at least 1MiB Bump the minimum stack size to at least 1MB Jul 23, 2024
@waahm7 waahm7 merged commit 67601bb into main Jul 24, 2024
53 checks passed
@waahm7 waahm7 deleted the musl-stack-issue branch July 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants