Fix -Wuseless-cast
compiler warnings
#1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
#973
This warning exists in GCC only (not Clang), and for C++ only (not C)
Description of changes:
-Wuseless-cast
warning to the "header checker"array_list.inl
-Wuseless-cast
warning inmath.inl
size_t
asunsigned long
and require casting touint64_t
(akaunsigned long long
). While other platforms definesize_t
asunsigned long long
and warn about useless casts if you cast it touint64_t
. My first commit attempted to only do casts on those platforms, but it was more complex than simply ignoring the warning.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.